Enhancement: Extension name tooltips for tool banners#3250
Merged
jamadeo merged 1 commit intoJul 17, 2025
Conversation
LordMelkor
force-pushed
the
feature/extension-name-tooltips
branch
2 times, most recently
from
July 4, 2025 03:12
efdda3b to
02de8a2
Compare
jamadeo
approved these changes
Jul 16, 2025
| return `capturing window "${truncate(getStringValue(args.window_title))}"`; | ||
| } | ||
| return 'capturing screen'; | ||
| return `capturing screen`; |
Member
There was a problem hiding this comment.
nit: unnecessary backtick quotes
| {extensionTooltip ? ( | ||
| <TooltipWrapper tooltipContent={extensionTooltip} side="top" align="start"> | ||
| <span className="ml-[10px] cursor-pointer hover:opacity-80"> | ||
| {(() => { |
Member
There was a problem hiding this comment.
You could avoid duplication by extracting the inner part like:
const toolLabel = (
<span className="ml-[10px]">
{(() => {
const description = getToolDescription();
if (description) {
return description;
}
// Fallback tool name formatting
return snakeToTitleCase(toolCall.name.substring(toolCall.name.lastIndexOf('__') + 2));
})()}
</span>
);
return (
<ToolCallExpandable
...
{extensionTooltip ? (
<TooltipWrapper ... >{toolLabel}</TooltipWrapper>
) : (
{toolLabel}
)
...
Contributor
Author
There was a problem hiding this comment.
@jamadeo have addressed this in the latest version of the code! Please take a look.
Implements extension name tooltips on tool banners, combining the best of both the original feature and the latest main branch improvements: Features: - Extension name tooltips (e.g., "memory extension") appear on hover for tools that belong to extensions (identified by __ separator in tool names) - Enhanced loading indicators with LoaderCircle animation and improved layout - DRY code implementation that eliminates duplication in tool label rendering Implementation: - Add TooltipWrapper import for tooltip functionality - Add getExtensionTooltip() helper to extract extension names from tool names - Add getToolLabelContent() helper to eliminate code duplication - Use conditional styling with cn() utility for tooltip-specific classes - Preserve all main branch UI improvements (LoaderCircle, layout structure) - Conditionally wrap tool labels with TooltipWrapper when extension detected The tooltip appears with "top" positioning and "start" alignment, providing contextual information about which extension provides each tool without cluttering the interface.
LordMelkor
force-pushed
the
feature/extension-name-tooltips
branch
from
July 17, 2025 17:53
02de8a2 to
8c510a3
Compare
jamadeo
approved these changes
Jul 17, 2025
jamadeo
left a comment
jamadeo
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks for doing this.
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Extension Name Tooltips to Tool Banners
Overview
Adds hover tooltips to tool banners showing extension names (e.g., "developer extension") without cluttering the UI. This builds on the clean tool descriptions from #3231 by providing extension information on demand through tooltips.
Features
developer__shell→ "developer extension")__separator show no tooltipScreenshot
Implementation
ui/desktop/src/components/ToolCallWithResponse.tsxgetExtensionTooltip()helper functionTooltipWrappercomponent withalign="start"Testing
Provides extension information on demand while maintaining a clean interface.